Current situation with garbage collection

[Toyoo]

@pangolin

The bloom filter contains a list of 90% of the pieces that should be stored on the node.
The node receives it, retains those pieces, and the rest is sent to trash. But this trash dosen’t also includes the rest of 10% of good pieces?
So the nodes can delete 10% of good pieces too? What I got wrong?

Please refer to my attempt of explaining bloom filters, maybe it will help here.

@pangolin

As for the additional database requirements… I always thaugt satellites already having a database of all pieces. Is this true?

A database of all existing pieces. They shouldn’t need to store information on removed pieces.

@littleskunk

what size a single pieceID has

32 bytes.

@pangolin

It can not receive a bloom filter either when it is offline.

Each bloom filter has a chance of garbage-collecting each unused piece. So after a piece is removed, if you miss one bloom filter, the next one will do the job.

@pangolin

adding it to a bloomfilter again

Bloom filters do not store information on which pieces should be deleted. Please refer to my post linked above for explanation.

@pangolin

I can’t see any advantage over direct deletes from my point of view as a SNO.

In most scenarios, especially ones where you do not have enough memory to cache file metadata, batch removals are faster. Your node only needs to scan each subdirectory once, as opposed to walking them randomly.