kaloyan
February 22, 2023, 1:42pm
22
I can confirm that division by zero in floats can produce NaN, +Inf, -Inf.https://play.golang.com/p/9jDjcvCwmaq
And these are invalid JSON values.
Looking at the code, I found only one division operation that may cause this, and a zero check has already been added for v1.73, which will be rolled out soon.
committed 06:50PM - 06 Feb 23 UTC
The used space graph values are correct when a single satellite is
selected but … wrong for 'All satellites'. This is related to the
queries for getting the individual disk usages for all satellites
per day and the summary and average for all satellites per day:
1. dividing the sum of at_rest_total by the total_hours is wrong.
Simply put, we were assuming that, for example (4/2)+(6/3) equals
to (4+6)/(2+3), assuming we had 4 and 6 at_rest_total values with
2 and 3 respective hours.
2. To get the average, we need to first find the sum of the
at_rest_total_bytes for each timestamp across all satellites
before taking the average of the sums instead of just taking the
average from the individual satellite values.
Closes https://github.com/storj/storj/issues/5519
Change-Id: Ib1314e238b695a6c1ecd9f9171ee86dd56bb3b24
4 Likes