# GitHub Pull request question

**URL:** <https://forum.storj.io/t/github-pull-request-question/27730>\
**Category:** FAQ\
**Created:** [September 3, 2024, 10:50am UTC](https://forum.storj.io/t/github-pull-request-question/27730 "2024-09-03T10:50:56Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![MarviBiene](https://storj.bcdn.literatehosting.com/user_avatar/forum.storj.io/marvibiene/32/1124_2.png) [@MarviBiene](https://forum.storj.io/u/MarviBiene)\
**Post date:** [September 3, 2024, 10:50am UTC](https://forum.storj.io/t/github-pull-request-question/27730/1 "2024-09-03T10:50:56Z")

</div>

Hello,

I have a small question. I opened a Pull request on GitHub. It’s my first on, so I am still learning on how to do things on GitHub.

> <https://github.com/storj/storj/pull/7122>
>
> As ZkSync Lite is deprecated the link is changed to the ZkSync Era page.
> 
> 
> Wh…at: 
> I replaced the ZkSync Lite link with the ZkSync Era link.
> 
> Why:
> ZkSync Lite was replaced with ZkSync Era. So it is useless to direct to the ZkSync Lite explerer.
> 
> Please describe the tests:
> - Test 1: Check if the Link works
>  
> Please describe the performance impact:
> No longer gets directed to the ZkSync Lite page, as it is not in use anymore.
> 
> 
> \## Code Review Checklist (to be filled out by reviewer)
> - \[X \] NEW: Are there any Satellite database migrations? Are they forwards \_and\_ backwards compatible? 
> - \[X\] Does the PR describe what changes are being made?
> - \[X\] Does the PR describe why the changes are being made?
> - \[? \] Does the code follow \[our style guide\](https://github.com/storj/docs/blob/main/code/Style.md)? -\> File not Found
> - \[? \] Does the code follow \[our testing guide\](https://github.com/storj/docs/blob/main/code/Testing.md)? -\> File not Found error
> - \[X\] Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
> - \[X \] Does the new code have enough tests? (\*every\* PR should have tests or justification otherwise. Bug-fix PRs especially)
> - \[X\] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and \[higher level\](https://github.com/storj/docs), diagrams?)
> - \[X\] Does any documentation need updating?
> - \[X\] Do the database access patterns make sense?

I only changed a link and build it myself. It is already running on my server and is working fine.

I accepted the cla too. Did I miss something or do I just have to wait?

Thank you in advance

---

<div class="post-metadata">

**Author:** ![Alexey](https://storj.bcdn.literatehosting.com/user_avatar/forum.storj.io/alexey/32/41_2.png) [@Alexey](https://forum.storj.io/u/Alexey)\
**Post date:** [September 4, 2024, 3:46am UTC](https://forum.storj.io/t/github-pull-request-question/27730/2 "2024-09-04T03:46:54Z")

</div>

Hello @MarviBiene,  
It requires a rebase to the `main` and two reviews after.  
Please rebase it, and I will ping the team to check it.  
Thank you for your contribution!

---

<div class="post-metadata">

**Author:** ![MarviBiene](https://storj.bcdn.literatehosting.com/user_avatar/forum.storj.io/marvibiene/32/1124_2.png) [@MarviBiene](https://forum.storj.io/u/MarviBiene)\
**Post date:** [September 4, 2024, 10:41am UTC](https://forum.storj.io/t/github-pull-request-question/27730/3 "2024-09-04T10:41:02Z")

</div>

Hello,  
Thank you very much. Do I have to notify you or someone every time I want to change something? Or is it enough to just open a pull request and keep it up to date with the branch?

---

<div class="post-metadata">

**Author:** ![Alexey](https://storj.bcdn.literatehosting.com/user_avatar/forum.storj.io/alexey/32/41_2.png) [@Alexey](https://forum.storj.io/u/Alexey)\
**Post date:** [September 5, 2024, 3:39am UTC](https://forum.storj.io/t/github-pull-request-question/27730/4 "2024-09-05T03:39:50Z")

</div>

No, you do not need to notify, we have a monitoring bot for the PRs, just not enough time.  
But if you wouldn’t get any respond for a while you may add something to the PR or ask the same here on the forum. You do not need to use a private messages too, we an Open Source project and want to be as transparent as possible.

So, I would like to move this thread to a public area if you do not mind. This would make things not only transparent, but also the mention would be added to a shared PR/issue, generating a new comment on the related item and the team would get a notification. It may help to improve priorities and get things done faster.

Thank you!

> [@MarviBiene](#):
>
> Or is it enough to just open a pull request and keep it up to date with the branch?

Yes, it’s enough, but as I said earlier - if you wouldn’t get any respond within a week - it’s a time to ping us 🙂

---

<div class="post-metadata">

**Author:** ![MarviBiene](https://storj.bcdn.literatehosting.com/user_avatar/forum.storj.io/marvibiene/32/1124_2.png) [@MarviBiene](https://forum.storj.io/u/MarviBiene)\
**Post date:** [September 5, 2024, 7:09am UTC](https://forum.storj.io/t/github-pull-request-question/27730/5 "2024-09-05T07:09:43Z")

</div>

Thank you. You can move this thread to a public area, I don’t have a problem with that.

I will try to add some features to the multinode dashboard, that the node dashboard already has. (Like dark mode) So It will help me in the future.

---

<div class="post-metadata">

**Author:** ![Alexey](https://storj.bcdn.literatehosting.com/user_avatar/forum.storj.io/alexey/32/41_2.png) [@Alexey](https://forum.storj.io/u/Alexey)\
**Post date:** [September 6, 2024, 2:28am UTC](https://forum.storj.io/t/github-pull-request-question/27730/6 "2024-09-06T02:28:55Z")

</div>

Made this topic public on September 6, 2024, 2:28am UTC


