Badger cache: are we ready?

[Alexey]

@andrew2.hart

And a windows user reported than he had corrupted badger cache after windows restarts.

This need to be investigated. I wouldn’t expect it to be corrupted due to a normal restart.

@andrew2.hart

docker exec -it storagenode1 /app/storagenode issue-apikey --config-dir config --identity-dir identity
Error: Error starting master database on storage node: Cannot acquire directory lock on “config/storage/filestatcache”. Another process is using this Badger database. error: resource temporarily unavailable

By the way, I accidentally found a solution for the docker node when the badger cache is enabled: you shouldn’t enable the badger cache in the config.yaml file, you need to use a command line option

@Dr.Ko

--pieces.file-stat-cache=badger \
--pieces.enable-lazy-filewalker=false

after the image name, so when you exec the key issue command in the docker container, it didn’t try to lock a filecache, because it’s not enabled in the config.
This also explains why it works for my Docker node , because I enabled it exactly like that, because it’s more convenient if you use a docker compose:

services:                                                                                      (3/3 results) [1190/2149]
  storagenode2:
    container_name: storagenode2
    restart: always
    stop_grace_period: 300s
    image: storjlabs/storagenode:latest
...
    command:
      - --pieces.enable-lazy-filewalker=false
      - --pieces.file-stat-cache=badger
    #   - --healthcheck.details=true
    #   - "--operator.wallet-features=zksync"