GitHub Pull request question

MarviBiene · September 3, 2024, 10:50am

Hello,

I have a small question. I opened a Pull request on GitHub. It’s my first on, so I am still learning on how to do things on GitHub.

github.com/storj/storj

Change Wallet list from ZkSnyc Lite to Era on Multinode Dashboard

storj:main ← MarviBiene:patch-1

opened 05:55PM - 25 Aug 24 UTC

MarviBiene

+1 -1

As ZkSync Lite is deprecated the link is changed to the ZkSync Era page. Wh…at: I replaced the ZkSync Lite link with the ZkSync Era link. Why: ZkSync Lite was replaced with ZkSync Era. So it is useless to direct to the ZkSync Lite explerer. Please describe the tests: - Test 1: Check if the Link works Please describe the performance impact: No longer gets directed to the ZkSync Lite page, as it is not in use anymore. ## Code Review Checklist (to be filled out by reviewer) - [X ] NEW: Are there any Satellite database migrations? Are they forwards _and_ backwards compatible? - [ X] Does the PR describe what changes are being made? - [ X] Does the PR describe why the changes are being made? - [? ] Does the code follow [our style guide](https://github.com/storj/docs/blob/main/code/Style.md)? -> File not Found - [? ] Does the code follow [our testing guide](https://github.com/storj/docs/blob/main/code/Testing.md)? -> File not Found error - [ X] Is the PR appropriately sized? (If it could be broken into smaller PRs it should be) - [X ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially) - [ X] Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?) - [ X] Does any documentation need updating? - [ X] Do the database access patterns make sense?

I only changed a link and build it myself. It is already running on my server and is working fine.

I accepted the cla too. Did I miss something or do I just have to wait?

Thank you in advance

Alexey · September 4, 2024, 3:46am

Hello @MarviBiene,
It requires a rebase to the main and two reviews after.
Please rebase it, and I will ping the team to check it.
Thank you for your contribution!

MarviBiene · September 4, 2024, 10:41am

Hello,
Thank you very much. Do I have to notify you or someone every time I want to change something? Or is it enough to just open a pull request and keep it up to date with the branch?

Alexey · September 5, 2024, 3:39am

No, you do not need to notify, we have a monitoring bot for the PRs, just not enough time.
But if you wouldn’t get any respond for a while you may add something to the PR or ask the same here on the forum. You do not need to use a private messages too, we an Open Source project and want to be as transparent as possible.

So, I would like to move this thread to a public area if you do not mind. This would make things not only transparent, but also the mention would be added to a shared PR/issue, generating a new comment on the related item and the team would get a notification. It may help to improve priorities and get things done faster.

Thank you!

Yes, it’s enough, but as I said earlier - if you wouldn’t get any respond within a week - it’s a time to ping us

MarviBiene · September 5, 2024, 7:09am

Thank you. You can move this thread to a public area, I don’t have a problem with that.

I will try to add some features to the multinode dashboard, that the node dashboard already has. (Like dark mode) So It will help me in the future.