If I edit my post but change my mind before saving and click the trashcan to discard changes this message shows up instead
It tells me the post will be discarded. I’m not discarding a post. I’m discarding edits.
I think it always was like this? I just do not remember
Yes. It’s always been this way. Editing a post uses the same code as creating a new message. You can change the text here: https://forum.storj.io/admin/customize/site_texts?q=do%20you%20want%20to%20discard%20your%20post
it will change it for both edits and new messages. If there is text you find less confusing (“Do you want to discard your post or edits?”), you can put it there.
If you want it to be different, you can make a suggestion at Feature - Discourse Meta with a recommendation.
But I’ll admit that the message can be confusing.
It only takes one try/forum member to get the picture. No biggie…
Indeed looks like the text was always like this — but I feel earlier the dialog was providing more context so it was less confusing.
Form another forum:
Nobody reads the text above buttons, but buttons tell a sane story —- discard, save draft for later, keep editing, so the brain makes a connection: this dialog is about editing, I can save the draft or discard (obviously, my edits, not the whole post, because this is what the last buttion is discussing)
I think this dialog was replaced with a new version. I do remember we have had the similar suggestion earlier.
Wasn’t clearer to show both buttons next to eachother?
SAVE CANCEL
After clicking Save, it saves and exits the edit mode.
After clicking Cancel, it asks for confirmation with message and options Yes / No.
That X is somehow hard to hit with fat fingers on mobile devices and for discarding, you get 2 confusing options that mean the same thing: Discard and Cancel. 
That’s why it’s “discard changes”, not just “discard” and “cancel”, which is “do nothing, get me out of here” action known universally.
Pressing cancel should never lead to data loss.
This was old design an it was confusing.after you press X, what could cancel cancel - cancelling the message or saving it? There was no context to answer the question correctly.
Next iteration introduced the wrong context “discard the post” (what?!) and now it’s correct.
That’s why corext explicit actions are importnat and generic confirm/cancel are not to be used, albeit coders like them because look generic reusable dialog.
Extreme case to illustrate the issue I’m taking about
Cancel the Very Important Operarion?
[.cancel ] [ cancel ]