Should I implement the notification system for satellite to the multinode dashboard?

@Alexey @jtolio The satellite dashboard has a very good notification system but the multinode dashboard doesn’t should I implement the notification system for satellite to the multinode dashboard??

I think you may do so, all SNOs who use the multinode dashboard would thank you!

You may also take a look on other feature requests there: Search results for '#ideas-and-suggestions:sno-feature-requests-voting tags:multiple-nodes,multi-node-dashboard order:latest' - Storj Community Forum (official)

Yup I myself faced some problems due to that.

Hey @Alexey, sorry for being inactive due to health reasons, but I’ve fully recovered now. I’m ready to start working on it

2 Likes

I’m glad to read that you have fully recovered!
Welcome back!

1 Like

Hey @Alexey can you review this issue please. Also I added the mechanism for the notification I was waiting for any core member to review it. Then I’ll implement it everywhere in the multinode.
Thank you.

3 Likes

Added a commentary to the issue. Thank you for contribution!

1 Like

Hey @Alexey Can you tell anyone from the core team to review the notifications PR as it has the vuetify integration. With it I can add dark mode too. It been up for more than a week.

4 Likes

it’s out of date and has failed tests
https://build.dev.storj.tools/job/storj/job/PR-7164/5/display/redirect
Could you please fix that?

Please make Jenkins happy :slight_smile:

I fixes all the lint and build related errors. But it fails on satellite/console tests where in this PR, I have done nothing. So to ensure I ran go test inside satellite/console but all the tests passed successfully. After seeing the error I realized that the error was due to concurrent access so I ran go test -parallel 6 -p 12 -vet=off $COVERFLAGS -timeout 32m -json -race ./... 2>&1 inside satellite/console, which also successfully cleared all the tests.

Does the make test command runs all the tests in the Jenkins workflow?

Seems it’s green and happy?
https://build.dev.storj.tools/blue/organizations/jenkins/storj/detail/PR-7164/11/pipeline

I would ask the team

I don’t know how it become happy cause the only thing I have done is restart the tests again.:sweat_smile::sweat_smile:

Oh, seems it’s failed again.

Fixed it. All green now. I accidentally deleted the dist and public folder which fails the backward-compatibility error.:sweat_smile::sweat_smile:

1 Like

This is a good sign!
I hope it would be merged soon. Please be aware that the core team is available only on a workdays in US working hours.

1 Like

Another question do you use the default .golangci.yml for linting golang files? Because another one of my PR is struck due to some golang lint issues. :sweat:

Yeah, then I can add dark mode on multinode and add the notifications to all other places.

I do not, because I’m not a developer here :slight_smile: (yet).
I can help with the code though, but no best practice, sorry.

The Jenkins setup doesn’t look reliable. My small PR touches only a single test file. Jenkins suddenly claims errors in 15 other tests.

I recall being able to at least schedule another run of the job, but I don’t see the button there anymore. :person_shrugging:

Finally jenkins is happy with all of my PRs. :grinning::grinning: